search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.46k stars 277 forks source link

Weird navbar and javascript popups issue #426

Closed tbs closed 10 years ago

tbs commented 11 years ago

When you open a javascript popup (in pages or using bookmarklet) the navbar margin is moved in negative way. And opening a new popup restores the navbar position. Is it a known issue?

What I have installed is basically Tab Mix Plus and Tree Style Bar.

screenshot is attached or by this link http://i3.minus.com/i2uz6EUK4NqlZ.png (the main window is maximized)

bug tree style bar

It's very annoyance.

tbs commented 11 years ago

Feedback please?

tbs commented 11 years ago

ok, disabled Tab Mix Plus and Stylish, so I have almost no addons installed, but problem still occur. I need feedback to confirm issue.

tbs commented 11 years ago

Ok, now running without addons, just tree style tab.

Here is the message on error console when the issue occur:

Timestamp: 16/01/2013 23:13:18 Error: this.docShell is null Source File: chrome://global/content/bindings/browser.xml Line: 323

tbs commented 11 years ago

What is more frustrating than report a bug and don't receive any feedback? sadly.

piroor commented 11 years ago

Hmm, I couldn't reproduce this on my Firefox 19 on Windows Vista with TST's latest development build. Could you try the development build? http://piro.sakura.ne.jp/xul/xpi/nightly/

tbs commented 11 years ago

I tried today again on current Nighly, look the screenshot bellow:

http://i.minus.com/icXRdnGPGdib6.png (this window is maximized)

Only Tree Style Tab is enabled, and I still able to reproduce the bug. Don't ask me the right steps, this is a mystery. What I can confirm is that bug trigger when you open some javascript window (also bookmarklets) or new Firefox window (ctrl+n), but it is hard to reproduce because it occur by random after long session.

Help me to help you find the culprit.

ps: error console is blank, nothing to share with you. I'm already using the Nightly build for both, FF and the addon.

kepreon commented 11 years ago

I have the same issue with Firefox 21 (Win7) and the latest nightly of TST. The browser window looks fine if it's not maximized, but maximized the top is cut off as in the pictures tbs posted. I have to restart the browser to get it back to normal.

I've can reproduce it 100% of the time opening a new window. It also happens when clicking on Javascript links. I think it started around the time I upgraded to FF20 (and I just got 21 today with no change).

The following error is in my error console:

Timestamp: 5/14/2013 10:27:38 AM Error: this.docShell is null Source File: chrome://global/content/bindings/browser.xml Line: 323

piroor commented 11 years ago

Oh, OK, I've confirmed. This happens with the combination of two preferences:

If TST works correctly, "browser.tabs.onTop" should be always "false" when you use the vertical tab bar. TST controls the preference automatically, but someone (possible another tab related addon on your Firefox) possibly reset it to "true" unexpectedly.

Go to "about:config" and turn "browser.tabs.onTop" to "false", then this issue will go away. If it can't be turned to "false", it is controlled by another addon so you have to find it out and disable the feature conflicting with TST.

kepreon commented 11 years ago

Thanks for the quick response and the pointer. I found that my originalState was true, and onTop was false, but when I opened a new window, onTop would become true. I disabled all add-ons except TST and still reproduced it, so disabled everything I could, cleared out all TST settings, and re-enabled everything and now I can't reproduce it. Could these combinations of non-default preferences cause TST to change this variable? I'll keep my eyes out if it happens again, but I can't reproduce it now (and have a better workaround than restarting).

user_pref("extensions.treestyletab.prefsVersion", 9); user_pref("extensions.treestyletab.tabbar.autoHide.mode.fullscreen", 0); user_pref("extensions.treestyletab.tabbar.narrowScrollbar", false); user_pref("extensions.treestyletab.tabbar.shrunkenWidth", 24); user_pref("extensions.treestyletab.tabbar.width", 237); user_pref("extensions.treestyletab.tabsOnTop.originalState", true); user_pref("extensions.treestyletab@piro.sakura.ne.jp.install-event-fired", true);

kepreon commented 11 years ago

I got it to happen again, with only a few overridden TST settings. I disabled all plugins and extensions, restarted, and can get it to happen when I open a Javascript link to a PDF (even after disabling built-in pdfjs). Is there anything in FF that can reset this value?

tbs commented 11 years ago

Oh nice, some feedback!!! I'm waiting for months... unfortunately, as I said before, it occur even without any addon installed/enabled.

My config browser.tabs.onTop already was set to false prior to post here.

I used a search tool to lookup all extension files, only in TST it found string browser.tabs.onTop, so I assume only your extension is toggling that config.

piroor please lets try to find the culprit quickly, I can do everything you need any time any day, 24h, I'm looking this page each 5 minutes.

tbs commented 11 years ago

Ok found, an article about lock option. I'll try to lock tabsOnTop to false. Back later to report if it worked.

Info: http://kb.mozillazine.org/Locking_preferences

tbs commented 11 years ago

Oh, now worked the lock. It changes the config to italic.

Lets see the result, if failed I back to report.

tbs commented 11 years ago

ok just posting here to confirm the locking config worked like a charm.

piroor commented 11 years ago

I still cannot reproduce this problem, however, I think there is one possibility: Your Firefox possible restores "tabsontop=true" state on every startup by an old information stored in your profile.

On old Firefox, "tabs on stop" state was saved to "localstore.rdf", not "prefs.js" (accessible from about:config). By this change http://hg.mozilla.org/mozilla-central/rev/440b585a2896#l3.14 Firefox currently saves the state of "tabs on top" to your prefs.js, however, if an old information in localstore.rdf still there, Firefox always restores the old state from localstore.rdf.

Please open your localstore.rdf by any text editor, and if you can see 'tabsontop="true"' in the file, you should remove it and overwrite the file.

kepreon commented 11 years ago

Yes, you are correct - updating that file solved my problem. Thanks for finding that change; I never would have figured it out!

piroor commented 10 years ago

Can I close this topic?

kepreon commented 10 years ago

Yes, feel free to close. I have not had this problem since applying your fix.

On Tue, Oct 8, 2013 at 9:20 AM, piroor notifications@github.com wrote:

Can I close this topic?

? Reply to this email directly or view it on GitHubhttps://github.com/piroor/treestyletab/issues/426#issuecomment-25904888 .