search

piroor / treestyletab

Tree Style Tab, Show tabs like a tree.
http://piro.sakura.ne.jp/xul/treestyletab/
Other
3.46k stars 277 forks source link

New tabs appended to end instead of as child of current tab, in Firefox Nightly #822

Closed nnethercote closed 9 years ago

nnethercote commented 9 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1108555 changed something about Firefox that breaks TST's handling of new tabs -- they now get appended at the end of the tab list, instead of being appended to the current tab's child list. See https://bugzilla.mozilla.org/show_bug.cgi?id=1108555#c10.

mikeconley commented 9 years ago

This sounds a lot like issue 760 rearing its head again - the patch in bug 1108555 changed the signature of openLinkIn again, so perhaps the regex in windowHelper isn't matching properly?

LordJZ commented 9 years ago

816 should fix this. Works for me on latest Nightly.

TteokbokkiNari commented 9 years ago

Thanks a ton, @LordJZ! Can confirm it also works for me on the latest nightly.

ripdog commented 9 years ago

Thanks LordJZ. Here's a prebuilt XPI for convenience, until piroor comes out of hiding again.

http://a.pomf.se/hrnvbs.xpi

tiagoad commented 9 years ago

Same on OS X, thanks @ripdog, that fixed it.

Vest commented 9 years ago

Just in case, the last time when I got this issue, the nightly build helped me: http://piro.sakura.ne.jp/xul/xpi/nightly/

TteokbokkiNari commented 9 years ago

@Vest, yes, but a change in the Firefox nightlies made it not work again, and @piroor is busy with other things right now, so @LordJZ's fix isn't getting commited into the nightly TST.

ibrahima commented 9 years ago

Thanks @LordJZ and @ripdog , the fix still works on the latest nightly!

piroor commented 9 years ago

Can I close this issue?

nnethercote commented 9 years ago

Can I close this issue?

Yes. I have confirmed that the new nightly build of TST works correctly in a trunk build of mozilla-central. Thank you for the updated nightly build.