search

piroor / tst-lock-tree-collapsed

Add ability to lock specific tree as "collapsed".
Mozilla Public License 2.0
5 stars 2 forks source link

ABP compatibility problem #15

Open alith opened 3 years ago

alith commented 3 years ago

When a popup tab is cloced by ABP, TST keep displaying a "new tab", that is unclosable (sometimes the close button does nothing, sometimes it makers the multiple tab dialog window open with the tab that opened the popup as parent, and the phantom tab as child (even though I tried to close the phantom tab) ) Ultimately, it messes with the order of tab kept in TST, for example, I'm unable to access the last tab of the tree via TST, I need to use next/previous tab shortcuts.

I'm not sure what is happening, but IMHO it looks like when ABP closes a tab, this extension prevents TST from registering that tab as closed... therefore the phantom tab being displayed and the problem of tab index.

I have never looked at how TST or this extension is implemented, but that's what it looks like.

Anyway, thanks for your work, keep me posted or ask me precision if you need to!

piroor commented 3 years ago

Could you describe steps to reproduce in a format like this?:

 1. Start Firefox with clean profile.
 2. Install TST.
 3. Install ABP from https://addons.mozilla.org/firefox/addon/adblock-plus/
 4. Open https://example.com/.
 5. Click the link.

Expected result:
a tab is opened and closed immediately.

Actual result:
a tab is opened and closed but a phantom item is left in the sidebar.
alith commented 3 years ago

Sorry for the late response, the website where I experienced this has changed its popup advertisement, so I'm having trouble to reproduce at the moment, I'll signal when I get an other example.

On Wed, 29 Sept 2021 at 19:27, piroor @.***> wrote:

Could you describe steps to reproduce in a format like this?:

  1. Start Firefox with clean profile.
  2. Install TST.
  3. Install ABP from https://addons.mozilla.org/firefox/addon/adblock-plus/
  4. Open https://example.com/.
  5. Click the link.

Expected result: a tab is opened and closed immediately.

Actual result: a tab is opened and closed but a phantom item is left in the sidebar.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/piroor/tst-lock-tree-collapsed/issues/15#issuecomment-930383408, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRLR4XRYHX22RWPXR7FN3UEND65ANCNFSM5D24E4JA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

piroor commented 3 years ago

OK, I'm still waiting more information when you see same problem in other situation.

alith commented 1 year ago

I never encountered this again, probably should mark as closed.