pirovc / ganon

ganon2 classifies genomic sequences against large sets of references efficiently, with integrated download and update of databases (refseq/genbank), taxonomic profiling (ncbi/gtdb), binning and hierarchical classification, customized reporting and more
https://pirovc.github.io/ganon/
MIT License
87 stars 13 forks source link

Bugfix/target node tax #265

Closed pirovc closed 1 year ago

pirovc commented 1 year ago

add verification for the bug reported in #264 and additionally uses the add method from multitax, which would fail in the bug reported.

codecov-commenter commented 1 year ago

Codecov Report

Merging #265 (ffbaffb) into dev (af00a99) will increase coverage by 11.08%. Report is 111 commits behind head on dev. The diff coverage is 88.85%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##              dev     #265       +/-   ##
===========================================
+ Coverage   77.66%   88.74%   +11.08%     
===========================================
  Files          22       23        +1     
  Lines        2512     3457      +945     
===========================================
+ Hits         1951     3068     +1117     
+ Misses        561      389      -172     
Files Coverage Δ
src/utils/include/utils/IBFConfig.hpp 100.00% <100.00%> (ø)
src/utils/include/utils/LCA.hpp 96.92% <100.00%> (+0.14%) :arrow_up:
src/utils/include/utils/adjust_seed.hpp 100.00% <100.00%> (ø)
src/ganon-build/CommandLineParser.cpp 89.47% <96.55%> (+1.59%) :arrow_up:
src/ganon-classify/CommandLineParser.cpp 90.12% <91.17%> (+8.07%) :arrow_up:
...classify/hierarchical_interleaved_bloom_filter.hpp 93.75% <93.75%> (ø)
src/ganon/ganon.py 89.18% <88.46%> (-4.76%) :arrow_down:
src/ganon/classify.py 89.47% <88.23%> (-4.65%) :arrow_down:
src/ganon/table.py 97.68% <98.12%> (-1.22%) :arrow_down:
src/ganon/util.py 90.32% <93.90%> (+27.03%) :arrow_up:
... and 9 more

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more