feat: Friuli Venezia Giulia

pirxpilot / liftie

:ski: Clean, simple, easy to read, fast ski resort lift status.

https://liftie.info

BSD 3-Clause "New" or "Revised" License

67 stars 31 forks source link

Closed FezVrasta closed 10 months ago

FezVrasta commented 10 months ago

I made a single PR as they all share the same website as source

FezVrasta commented 10 months ago

Could you merge this when you have time please?

pirxpilot commented 10 months ago

Please address/fix issues outlined in the review comments. Then squash the history and force push to PR branch.

FezVrasta commented 10 months ago

I don't see any comments, have you published them?

pirxpilot commented 10 months ago

I don't see any comments, have you published them?

Yup. Not sure why you don't see them above. Any chance you somehow managed to collapse the comments? Direct link to review is here.

FezVrasta commented 10 months ago

No I can't see any comment. Could you send them again please?

pirxpilot commented 10 months ago

in: lib/tools/turismofvg.js

re: toTitleCase It's not needed: seems like the lift names are already properly capitalized in HTML.
re: fn It's not needed: 'close' and 'open' should be coerced automatically - pretty sure fn is not needed here

FezVrasta commented 10 months ago

done thanks