pirxthepilot / wtfis

Passive hostname, domain and IP lookup tool for non-robots
MIT License
889 stars 47 forks source link

Fail open on VT resolution errors #32

Closed pirxthepilot closed 2 years ago

pirxthepilot commented 2 years ago

Let processing continue if the VT resolutions call fails for any reason.

Tangential to #26 .

wech71 commented 2 years ago

This is important, as VT seems to have lowered the limits for new accounts to 1 request per minute instead of previous 4. At least my api key has the following limits, which makes wtfis always bail out on the first try.

Request rate | 1 lookups / min 1 lookups / day 31 lookups / month

pirxthepilot commented 2 years ago

@wech71 oh wow, that's rough. Didn't know the limit gets that low... 1 lookup/day seems too harsh.

Thanks for letting me know, will definitely work on this one next.

pirxthepilot commented 2 years ago

Addressed by #36 which is included in latest 0.5.0 release.

wech71 commented 11 months ago

Just for the record:

I created a new virus total account recently and now the limits are pretty generous

Request rate | 4 lookups / min 500 lookups / day 15.5 K lookups / month

Maybe there was some problem creating my older account, which I now have deleted (it still had the 1 Lookups per day limit)

pirxthepilot commented 11 months ago

@wech71 thanks for the update! Interesting that the limits are attached to the account.