codecov[bot]
commented
2 years ago Codecov Report
Base: 92.87% // Head: 92.87% // Decreases project coverage by -0.00% :warning:
Coverage data is based on head (
b77bd6a) compared to base (a510fdd). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #488 +/- ## ========================================== - Coverage 92.87% 92.87% -0.01% ========================================== Files 93 93 Lines 4365 4362 -3 ========================================== - Hits 4054 4051 -3 Misses 311 311 ``` | [Impacted Files](https://codecov.io/gh/pisa-engine/pisa/pull/488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine) | Coverage Δ | | |---|---|---| | [include/pisa/cursor/block\_max\_scored\_cursor.hpp](https://codecov.io/gh/pisa-engine/pisa/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine#diff-aW5jbHVkZS9waXNhL2N1cnNvci9ibG9ja19tYXhfc2NvcmVkX2N1cnNvci5ocHA=) | `86.66% <100.00%> (ø)` | | | [.../pisa/query/algorithm/block\_max\_maxscore\_query.hpp](https://codecov.io/gh/pisa-engine/pisa/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine#diff-aW5jbHVkZS9waXNhL3F1ZXJ5L2FsZ29yaXRobS9ibG9ja19tYXhfbWF4c2NvcmVfcXVlcnkuaHBw) | `98.11% <100.00%> (-0.04%)` | :arrow_down: | | [...isa/query/algorithm/block\_max\_ranked\_and\_query.hpp](https://codecov.io/gh/pisa-engine/pisa/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine#diff-aW5jbHVkZS9waXNhL3F1ZXJ5L2FsZ29yaXRobS9ibG9ja19tYXhfcmFua2VkX2FuZF9xdWVyeS5ocHA=) | `97.50% <100.00%> (-0.07%)` | :arrow_down: | | [...lude/pisa/query/algorithm/block\_max\_wand\_query.hpp](https://codecov.io/gh/pisa-engine/pisa/pull/488/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine#diff-aW5jbHVkZS9waXNhL3F1ZXJ5L2FsZ29yaXRobS9ibG9ja19tYXhfd2FuZF9xdWVyeS5ocHA=) | `98.73% <100.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We already do that for scores, and this is for consistency and simplicity. All uses of block_max_score in algorithms have been modified to take this change into account.
Fixes #474