search

pisa-engine / pisa

PISA: Performant Indexes and Search for Academia
https://pisa-engine.github.io/pisa/book
Apache License 2.0
941 stars 65 forks source link

C++20 Support #513

Closed elshize closed 1 year ago

elshize commented 1 year ago

This includes three things:

  1. Upgraded range-v3 to the latest version
  2. Fixed a namespace issue in our own code base
  3. Fixed CI (and added one C++20 build)

The last one is not really related to any of the changes, but it seems to be related to a cmake bug. Not sure what happened, I suspect the system cmake was updated in the base image. For some reason Debian doesn't have the last point version of 3.13 that was released in 2019 but stopped at 3.13.4, which had that bug that caused failures.

Anyhow, I thought it might be best to simply get cmake from upstream, and saw no reason not to use the latest version.

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.03% // Head: 93.03% // No change to project coverage :thumbsup:

Coverage data is based on head (9be8b9b) compared to base (272dce9). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #513 +/- ## ======================================= Coverage 93.03% 93.03% ======================================= Files 90 90 Lines 4497 4497 ======================================= Hits 4184 4184 Misses 313 313 ``` | [Impacted Files](https://codecov.io/gh/pisa-engine/pisa/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine) | Coverage Δ | | |---|---|---| | [include/pisa/codec/varintgb.hpp](https://codecov.io/gh/pisa-engine/pisa/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine#diff-aW5jbHVkZS9waXNhL2NvZGVjL3ZhcmludGdiLmhwcA==) | `62.57% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pisa-engine)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

elshize commented 1 year ago

Well, that was easier than I thought it would be

This how much faith you have in me? :grin: But seriously, it was just a using namespace bug on our side really. C++ standards are famously backwards-compatible to a point (this is actually big point of contention, because it also means you can't change bad old stuff much).