Remove UB and read-after-buffer in varintgb

pisa-engine / pisa

PISA: Performant Indexes and Search for Academia

https://pisa-engine.github.io/pisa/book

Apache License 2.0

942 stars 65 forks source link

Remove UB and read-after-buffer in varintgb #531

Closed elshize closed 1 year ago

elshize commented 1 year ago

Fixes #527

elshize commented 1 year ago

Spooky compiler business there...

The amount of this type of problems in our legacy code is staggering. In this case, it was easy to fix, mostly because I was easy enough to understand. But I'm not looking forward to debugging the bitvector based stuff. I think the real dragons be there.