search

pisa-engine / pisa

PISA: Performant Indexes and Search for Academia
https://pisa-engine.github.io/pisa/book
Apache License 2.0
942 stars 65 forks source link

Use rapidcheck to test codecs #535

Closed elshize closed 1 year ago

elshize commented 1 year ago

Rapidcheck makes failures reproducible, as opposed to what we had, which was using rand to generate some values.

elshize commented 1 year ago

For posterity, I am also noting here the existence of UB if we don't have T dst{0} for Clang in the include/pisa/memory.hpp file which caused immense pain for @elshize in particular.

Ah, thanks for immortalizing this low moment for me :joy: