pisa-engine / pisa

PISA: Performant Indexes and Search for Academia
https://pisa-engine.github.io/pisa/book
Apache License 2.0
932 stars 64 forks source link

Allow for system Boost installation #540

Closed elshize closed 1 year ago

elshize commented 1 year ago

Together with BOOST_NO_CXX98_FUNCTION_BASE, newer version of Boost fix builds on newer Clang versions. Currently, the way we pull Boost automatically only allows 1.67, and this one will fail to compile. This needs to be addressed in the near feature as well.


Replace boost::filesystem with std::filesystem

std::filesystem is now supported in all of our supported platforms, and Boost crashes on newer clang compilers.