search

pisa-engine / pisa

PISA: Performant Indexes and Search for Academia
https://pisa-engine.github.io/pisa/book
Apache License 2.0
941 stars 65 forks source link

Remove configuration.hpp #556

Closed elshize closed 11 months ago

elshize commented 1 year ago

Removes the configuration file that defined how many bits to use for quantization. Instead, this is now configured by CLI options.

Fixes #322

codecov[bot] commented 1 year ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d87bae5) 93.15% compared to head (5a3a5e5) 93.21%.

Files Patch % Lines
include/pisa/wand_data_compressed.hpp 92.00% 2 Missing :warning:
include/pisa/ensure.hpp 75.00% 1 Missing :warning:
include/pisa/wand_data_range.hpp 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #556 +/- ## ========================================== + Coverage 93.15% 93.21% +0.05% ========================================== Files 91 91 Lines 4514 4508 -6 ========================================== - Hits 4205 4202 -3 + Misses 309 306 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

elshize commented 11 months ago

Cool, this is good. And no default bits specified in the CLI, right? I couldn't see anything in app.* but just double checking.

Correct, no default because the option also says "do quantization", which means the default is no quantization bits.