pisa-engine / pisa

PISA: Performant Indexes and Search for Academia
https://pisa-engine.github.io/pisa/book
Apache License 2.0
941 stars 65 forks source link

Use [[likely]] and [[unlikely]] in c++20 mode #576

Closed elshize closed 9 months ago

elshize commented 9 months ago

When compiling in the c++20 mode, use the standard [[likely]] and [[unlikely]] instead of GNU built-ins. It enables these directives on other platforms.

All uses of our macros had to be edited to remove the outer parentheses.

Implements: https://github.com/pisa-engine/pisa/issues/570

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aa8900b) 93.28% compared to head (e4963e9) 93.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #576 +/- ## ======================================= Coverage 93.28% 93.28% ======================================= Files 90 90 Lines 4454 4454 ======================================= Hits 4155 4155 Misses 299 299 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.