search

piscoTech / Workout

A simple iOS app that accesses Health data to export workout data to CSV for any use.
MIT License
43 stars 9 forks source link

Error with Workout Type: Preparation and Recovery #4

Closed markwk closed 7 years ago

markwk commented 7 years ago

New updates look great and glad to see all my workout types now. Unfortunately export and viewing individual items for "Preparation and Recovery" causes the app to die. I log my stretching sessions via this workout type. Not sure the cause. Tell me if you need more documentation to reproduce.

piscoTech commented 7 years ago

I've tried manually creating a workout of that type from the Health app but the app was able to view and export it correctly. Do you record it manually or via an app, if the latter do you know if it add additional data to the workout?

I've received some crash reports from Apple, I'll try to see if they are relevant to your issue, if you haven't already opt-in can you enable sharing data with developer to make sure I receive a crashlog?

piscoTech commented 7 years ago

@markwk Can you post a screenshot of the workout details from inside the Health app?

markwk commented 7 years ago

@piscoTech I log these via Workflow app. I'll check and try to send you more intel.

markwk commented 7 years ago

Here are a couple screenshots:

http://imgur.com/a/pULbl http://imgur.com/a/LhDvz

piscoTech commented 7 years ago

Unfortunately they're not helpful, the crash seems to happen here so it seems to be an overflowing error when converting from TimeInterval aka Double to Int but that's strange in your case, you seems to have no distance linked to the workout.

In any case I have some ideas in order to fix it but I'm still unable to reproduce this bug. Can you test it yourself with the pull request I'll open shortly or become a beta tester to test the release? (If the latter you direct message me on Twitter or on my site specifying the email of your Apple ID so I can invite you)

piscoTech commented 7 years ago

I was able to replicate the bug myself, it was caused by distance always being defined even for workout not distance related, causing a division by zero.

@markwk Expect an update soon that will fix the problem