pishoyg / coptic

This is a project that aims to make the Coptic language more learnable.
https://remnqymi.com/
GNU General Public License v3.0
6 stars 0 forks source link

[Flashcards/KELLIA] Content is Dependent on the XML Wrapping Width #145

Open pishoyg opened 3 months ago

pishoyg commented 3 months ago

Bug discovered in 6279509ed0f6a744474764819c4ce620dcbc1698. Reproducing the commit message:

[Flashcards/KELLIA] Run make flashcards test to pick up changes. The changes are supposed to affect formatting only. However, they seem to have caused the flashcards pipeline to insert a lot of
tags unnecessarily.

Here is how this happened:

  • We start wrapping the source XML files at 80 characters.
  • Our KELLIA binary reads them, and passes the content as is to the output TSV's.
  • Our Flashcards binary reads the TSV's, and replaces the newline characters with
    tags.

This looks like a bug that need to be resolved. Let's do it when we are more fluent in KELLIA! (The code is mostly copied.)

140 introduced a parameter to help solve the problem.

I believe the path forward is:

P.S. It's cleaner to do the above for all Flashcard pipelines.

pishoyg commented 3 months ago

146 is a more general version of this issue.

pishoyg commented 1 month ago

Tidy has a add-xml-space flag that could be helpful (see).

pishoyg commented 1 month ago

NOTE: #265.

pishoyg commented 1 month ago

This may no longer be the case. We need to verify.