search

pishoyg / coptic

This is a project that aims to make the Coptic language more learnable.
https://remnqymi.com/
GNU General Public License v3.0
10 stars 0 forks source link

[Crum/Flashcards] Use CSS Variables to Simplify Dialect Style Changes #235

Closed pishoyg closed 1 month ago

pishoyg commented 2 months ago

Here, to change the style of a dialect, you loop over every single element to add or remove styling classes to their class list. You could probably implement this by simply changing the value of some CSS variables, so you don't have to loop over all elements.

pishoyg commented 2 months ago

We can probably use the same code that we (mistakenly) placed in xooxle.ts. Both of them look at the parameter d.

pishoyg commented 1 month ago

Lots of things can be simplified in Crum's script.ts using CSS, so we won't have to loop over every element individually. Let's take a look at xooxle.ts as well.

pishoyg commented 1 month ago

Obsoleted by #278.