pishran / nova-rtl-theme

RTL layout for Laravel Nova.
MIT License
40 stars 10 forks source link

Some elements overlaps when using eminiarts/nova-tabs #10

Closed TheSETJ closed 3 years ago

TheSETJ commented 3 years ago

Hey, thanks for your great package.

To make my resource more compact, I installed eminiarts/nova-tabs package to make use of tabs for my relationships. Based on screenshots on the package's page:

image

And the fact that I'm using a package for making things RTL, I expected something like the following outcome:

image

But here is how it actually looks:

image

I'm not really good at styling and that's why I don't make a PR (I've managed to get to my expected outcome using some try and failure with inline styling). I hope it gets fixed soon.

I'm using v1.5.3 of your package and v3.14.0 of Laravel Nova.

FaridAghili commented 3 years ago

Hi, I never used nova-tabs package and I'm not able to reproduce your issue.

Show some code so I can test it.

TheSETJ commented 3 years ago

@FaridAghili Here you are:

https://github.com/TheSETJ/laravel-nova-overlapping-elements-using-nova-rtl-theme-and-nova-tabs

I didn't put effort into translation. By the way, the overlapping will be visible on a user's detail page.

FaridAghili commented 3 years ago

Thank you, I'll give it a try this weekend.


From: Sayyed Ehsan Taheri Javid notifications@github.com Sent: Monday, December 21, 2020 9:57:22 AM To: pishran/nova-rtl-theme nova-rtl-theme@noreply.github.com Cc: Farid Aghili faridaghili@hotmail.com; Mention mention@noreply.github.com Subject: Re: [pishran/nova-rtl-theme] Some elements overlaps when using eminiarts/nova-tabs (#10)

@FaridAghilihttps://github.com/FaridAghili Here you are:

https://github.com/TheSETJ/laravel-nova-overlapping-elements-using-nova-rtl-theme-and-nova-tabs

I didn't put effort into translation. By the way, the overlapping will be visible on a user's detail page.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pishran/nova-rtl-theme/issues/10#issuecomment-748788328, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBVKLIM6HXZBUURCGV3FETSV3TEVANCNFSM4UZFDQBQ.

FaridAghili commented 3 years ago

@TheSETJ Fixed in v1.5.5