Editing a palette color clones palette, does not change colors in image

piskelapp / piskel

A simple web-based tool for Spriting and Pixel art.

http://piskelapp.com

Apache License 2.0

11.14k stars 780 forks source link

Editing a palette color clones palette, does not change colors in image #497

Open stuartpb opened 8 years ago

stuartpb commented 8 years ago

Am I missing something here? Shouldn't editing a color in the palette change all pixels of that color in the image?

stuartpb commented 8 years ago

Also, palette indices should be tracked separately from pixel colors (since I might want to make two palette positions the same color in one frame, then different in the next, ie. when something is flashing). Looking at the file structure, it seems like that's not how layers are being saved (they appear to be saved as PNG), but maybe I'm just not looking closely enough (it's possible you're already using the RGBA values as 32-bit palette indices and performing palette transformations internally, in which case, I apologize in advance).

juliandescottes commented 8 years ago

Hi,

Shouldn't editing a color in the palette change all pixels of that color in the image?

Would be a nice feature, but not implemented for now. Palettes at the moment are just a way to pick colors easily.

JaredSartin commented 8 years ago

+1 to color changes!! I would love to fix multiple animation sets color pallets without filling or redrawing the colors.

vico93 commented 6 years ago

Any news about this? It would make recoloring far more easier than needing to use Photoshop/GIMP to replace colors

carlsmith commented 6 years ago

The Magic Bucket Tool fills every pixel of one colour with the primary or secondary colour, and it has apply to all layers and apply to all frames options. It's not quite what's being asked for, but would produce the same effect pretty quickly.

I thought palettes were per user, and essentially treated like an editor config option. Is that not how they're intended to work?

vico93 commented 6 years ago

In fact, if we're able to quickly replace the pallete it would be more easy. and it could repaint all colors at once

martin-braun commented 6 years ago

What this app really would make an outstanding experience would not just being this feature, but also when this works beyond the darker/lighter tool. Let me explain further. I draw a sprite and use the darker/lighter tool to make some lightning deep in my sprite, giving it a better appearance. Now the app should not save the new colors as pixel, but instead it should still save the original pixel color + the light change. When I change a palette color it should change all pixels including the ones that has been changed with the darker/lighter tool. After this process the darker/lighter spots should be reapplied. This would make this app the best for pixel art, ever.

blurymind commented 4 years ago

I started working on a feature that will let you apply the colors of a palette to the frame you are on. It requires a bit more involved work, as we need to properly do two new things in piskel:

store color index in frame pixels
keep track of color palette of frames (currently we can only keep track of all existing colors, but not on a per frame basis)
when a a frame is loaded and has no indexed pixels, automatically compute them and create a currentFrame palette
make sure new colors get added at the end of the array in a color palette, so indexes dont change (currently piskel uses objects instead of arrays on the current colors, so when iterated their index changes - new colors are inserted at random position in the current colors palette, so we cant use that as reference)

blurymind commented 4 years ago

I've got something working here https://github.com/blurymind/piskel/tree/piskel-plus

it needs some work and testing before it can be split into its own branch/PR