search

piskvorky / bounter

Efficient Counter that uses a limited (bounded) amount of memory regardless of data size.
MIT License
934 stars 47 forks source link

Add CI for testing/wheels with Windows/Mac #20

Open menshikh-iv opened 6 years ago

menshikh-iv commented 6 years ago

This lib contains a lot of C code, for this reason, we need to make wheels for our users without compiler

yaskevich commented 5 years ago

I would like just to confirm it would be perfect to have wheels package for Windows.

piskvorky commented 5 years ago

Yeah, wheels would be nice. @yaskevich can you help out? CC @mpenkov.

yaskevich commented 5 years ago

@piskvorky I am interested in this task to be completed. I never had experience with building wheels, but I have nothing against it. It there is a someone who could I ask about the details, it would be supercool. If not, I can try to do it by docs.

piskvorky commented 5 years ago

Building wheels is not difficult; the 3rd party tools and services (AppVeyor & co) will be the biggest pain. Hopefully @mpenkov and @menshikh-iv could answer your questions.

yaskevich commented 5 years ago

For starter, I built manually wheels package for Windows x64 and actual version of Python (3.7): https://github.com/yaskevich/bin/raw/master/bounter-1.1.0-cp37-cp37m-win_amd64.whl After that, I played with AppVeyor. I connected it to my fork of bounter and managed to make AppVeyor work. It produced wheels package: https://ci.appveyor.com/api/buildjobs/vx0kub8yyax1rfff/artifacts/dist%2Fbounter-1.1.0-cp37-cp37m-win_amd64.whl Binary mine and AppVeyor's are not the same, but I guess it's ok. Now original bounter repo is to be connected to AppVeyor, as well uploading built packages to PyPI has to be set up (credentials will be required). Also there is a question for which architectures wheels packages should be produced. I set up only Python 3.7 for Windows x64. It seems I cannot connect AppVeyor to others repo. By the way, is there any chat for bounter, gensim and stuff? Slack, Telegram, etc? I'm asking because I currently develop extension for gensim, and it would be cool to discuss some things.

piskvorky commented 5 years ago

There's gitter and there's twitter. But the Gensim mailing list and Github here are the liveliest :) What kind of extension are you working on?

@mpenkov can you please assist @yaskevich with setting up the release process for Bounter? Cheers.

mpenkov commented 5 years ago

@yaskevich Can you make a PR with the relevant AppVeyor config?

yaskevich commented 5 years ago

There's gitter and there's twitter. But the Gensim mailing list and Github here are the liveliest :) What kind of extension are you working on?

Thanks for links. It's just a graph visualization builder, something like this. The question is whether it should be either a function of gensim, or standalone module.

@mpenkov can you please assist @yaskevich with setting up the release process for Bounter? Cheers. @yaskevich Can you make a PR with the relevant AppVeyor config?

I've just made a PR #39. It is super simple, I guess it have to be more elaborate (e.g. support for more architectures, upload to PyPI).