search

piskvorky / bounter

Efficient Counter that uses a limited (bounded) amount of memory regardless of data size.
MIT License
934 stars 47 forks source link

Mimic the Counter interface #5

Open piskvorky opened 7 years ago

piskvorky commented 7 years ago

Wrap the low-level implementations (min count sketch, hash tables for key iteration...) in a Counter interface. The goal is to make Counter <-> Bounter switch trivial for users.

Methods that cannot be implemented due to algorithmic constraints (key iteration with min count sketch etc) should raise a NotImplementedError with a clear error message.

piskvorky commented 6 years ago

@isamaru what's the status here? Are we raising NotImplementedError consistently?

If not, can you list what needs to be done, so others can take this over?

souravsingh commented 6 years ago

I would be interested to pick this up. We just need to refactor the API to make it similar to Counter, right?

menshikh-iv commented 6 years ago

@souravsingh yes, but please finish your current sLDA project first.