Open bhargavvader opened 8 years ago
I have been going through the code of ldasemodel.py and had following questions:
Yes, @mjawa , you're absolutely right with both points 1 and 2.
The way forward here would be to somehow replace the lda_post
class with our existing ldamodel
without breaking anything while giving similar results.
However I have concerns because some parts of lda_post
are important for further implementing DIM later.
I think the steps ahead, in order, would be to first implement DIM, and then work on making things faster by integrating ldamodel
and making it distributed.
@bhargavvader : I see. I can start implementing DIM. I am new to gensim, can you please tell me some of the reasons why lda_post was used instead of ldamodel to begin with.
Mainly because I wanted to be sure to replicate the C code as much as possible to allow for easier testing and the option of including DIM. DIM uses methods in the ldapost
class.
It'll need some investigation to see to what extent ldamodel
can be used instead of ldapost
.
Dynamic Topic Models is a variation of LDA by Blei et al which takes time-tagged data and allows one to Topic Model data over time-periods. I have described it more in a series of blogs here, and this is the PR (#739) recently merged which implements it.
While the code is functionally correct, it could use some more work to make it even better. Some of the things which would be very useful for the same:
update_obs
and the optimization takes a lot time.What is also very useful is suggesting how the code can be made more user friendly, or alternate ways to take data as an input (for example, a dict or tuple such as
{data/document : time-stamp}
), and posting examples and results from training DTM on datasets.PRs to implement any of the suggestions or issues on improving performance would be particularly useful.
@piskvorky , @tmylk , could you add the
feature
label and whatever else would be appropriate so this is easier to find when someone wishes to help?