Open indrajeet307 opened 5 years ago
Yes, this is currently not supported. Are you able to make a PR?
The changes, I made, in s3.py file
I tried writing test but moto did not allow sending endpoint_url. I am getting authentication failed while trying to push commit.
You won't be able to push to our repository. That's by design. You need to fork our repository, push the changes to your own fork, and then open a pull request. Then we'll review the PR and merge your changes in.
Here's a guide that describes what you need to do: https://guides.github.com/activities/forking/
Let me know if you're up for it!
Duplicates #259
It's not duplication because calling client doesn't sending endpoint_url to session.client('s3', ....).
For anyone stuck on this thread, Boto3 now https://github.com/boto/boto3/issues/1375 environment variable AWS_ENDPOINT_URL_S3 as of 1.28.0. This worked as a workaround for me using localstack s3.
I cannot pass custom transport_params to s3_iter_bucket api, It defaults to using amazon s3. I am trying smart_open with a locally deployed minio server, that supports s3 like access.