Fix zstd compression in ab mode

ddelange commented 3 months ago

Title

Motivation

Fix #832

Tests

Added tests, confirmed they would fail without the change.

Work in progress

If you're still working on your PR, include "WIP" in the title. We'll skip reviewing it for the time being. Once you're ready to review, remove the "WIP" from the title, and ping one of the maintainers (e.g. mpenkov).

Checklist

Before you create the PR, please make sure you have:

[x] Picked a concise, informative and complete title
[x] Clearly explained the motivation behind the PR
[x] Linked to any existing issues that your PR will be solving
[x] Included tests for any new functionality
[x] Checked that all unit tests pass

Workflow

Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress. Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.

ddelange commented 3 months ago

@mpenkov could you merge https://github.com/piskvorky/smart_open/pull/828 so these unit tests can run on all python versions? I only tested cp311 on my machine, and Github CI currently only tests cp37.

mpenkov commented 3 months ago

OK, done.

ddelange commented 3 months ago

all green :+1:

mpenkov commented 3 months ago

Great work @ddelange! Thank you!

piskvorky / smart_open