search

pissang / clay-viewer

3D model viewer with high quality rendering and glTF2.0/GLB export
https://pissang.github.io/clay-viewer/editor/
BSD 3-Clause "New" or "Revised" License
767 stars 97 forks source link

Binary glTF #10

Closed nickkraakman closed 6 years ago

nickkraakman commented 6 years ago

Very impressive work, @pissang ! Would love to have the option to convert to binary glTF as well. Is this something you will add soon?

pissang commented 6 years ago

Thanks! @nickkraakman . Currently binary glTF export is in the viewer http://pissang.github.io/qtek-model-viewer/editor and native app. Will also add it to the converter later:)

nickkraakman commented 6 years ago

@pissang that is very good news, since we really wish to integrate glTF into our augmented reality workflow! And what about compression using WEB3D_quantized_attributes?

pissang commented 6 years ago

WEB3D_quantized_attributes is already supported in the converter, with -q --quantize argument.

And hope it can be helpful to your AR workflow :) Any suggestions are welcomed.

nickkraakman commented 6 years ago

You are an absolute hero! Thanks so much for your great work.

If we run into any specific AR-related issues with glTF, I will definitely let you know.

nickkraakman commented 6 years ago

Hi @pissang, I have created a microservice for our AR platform using your fbx2gltf converter, and it works amazingly well! We will import the converted models into the Unity game engine in runtime, which is finally possible thanks to glTF.

However, importing the models is a lot easier if we have the models in GLB format. Do you have a rough idea on when you plan to implement the GLB conversion option? We would be eternally grateful :-)

pissang commented 6 years ago

Hi @nickkraakman. Glad to hear it works well for your project! I spend all time on another project these weekdays. The developing of GLB export can be started from this weekends and finished in two or three days.

BTW is it needed for your project to embed the images in the GLB file?

nickkraakman commented 6 years ago

Hi @pissang, that timeline would be perfect! Really appreciate all your effort.

For our use case, the GLB would have to include the images as well, yes, since we want to import this one GLB file and have all the assets of the model inside of it. This way we have to make just one call to our server instead of multiple calls.

Please let me know if you need more info, and thanks again!

pissang commented 6 years ago

Hi @nickkraakman , I just add GLB export in the latest fbx2gltf script https://github.com/pissang/qtek/blob/master/tools/fbx2gltf.py. -b --binary is the argument.

nickkraakman commented 6 years ago

Hi @pissang, you rock! Thank you so much for this fast implementation.