search

pissang / clay-viewer

3D model viewer with high quality rendering and glTF2.0/GLB export
https://pissang.github.io/clay-viewer/editor/
BSD 3-Clause "New" or "Revised" License
767 stars 97 forks source link

"Roughness" artefacts [Win/Web] [0.1.1] #61

Open SibDiP opened 6 years ago

SibDiP commented 6 years ago

Test stand :

OS: Windows 10 64-bit CPU Intel Core i3 4160 @ 3.60GHz Haswell 22nm Technology   RAM: 8,00ГБ Dual-Channel DDR3 (9-9-9-24)   Motherboard: Gigabyte Technology Co. Ltd. H81M-S1 (SOCKET 0)   Graphics: SyncMaster (1680x1050@60Hz)    Intel HD Graphics 4400 (Gigabyte)   Storage: 119GB Samsung SSD 850 PRO 128GB (SSD), 5581GB Microsoft Storage Space Device  

Programm Info:

Version: 0.1.1 Platform: desktop (Win/Web)

Descripton:

Some gltf 3D models have a "roughness" artefacts, after import. It is always need to be decreased by 0.01 (to 0.49) for correct display.

Steps:

  1. Open qtek-model-viewer.exe
  2. Import 3D model (example_1 , example_2) | screenshot №1
  3. Сhange "Roughness" from default (0.5) to 0.49.

Screenshot

roughness

pissang commented 6 years ago

It happens when the roughness of pixel is near to 1. Fixed in https://github.com/pissang/claygl/commit/ef3db5caac07f9b0b30a2f6258aa300879edc0af