search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 690 forks source link

CMake subproject fixes #1091

Closed Tachi107 closed 1 year ago

Tachi107 commented 1 year ago

In this PR I've made some minor improvements to the CMake files so that Pistache plays more nicely when it is included as a subproject. See the individual commits for details.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1091 (43945e4) into master (5bf1a89) will decrease coverage by 0.19%. The diff coverage is n/a.

:exclamation: Current head 43945e4 differs from pull request most recent head 23b74b9. Consider uploading reports for the commit 23b74b9 to get more accurate results

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   78.30%   78.11%   -0.20%     
==========================================
  Files          53       53              
  Lines        6657     6657              
==========================================
- Hits         5213     5200      -13     
- Misses       1444     1457      +13
Impacted Files Coverage Δ
include/pistache/transport.h 53.75% <0.00%> (-5.00%) :arrow_down:
src/common/transport.cc 66.99% <0.00%> (-1.66%) :arrow_down:
src/client/client.cc 83.75% <0.00%> (-0.64%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Tachi107 commented 1 year ago

Il giorno ven 19 ago 2022 alle 08:21:35 -07:00:00, Kip @.***> ha scritto:

Thanks @Tachi107. I'm fine with it, notwithstanding the two CI failures on: NOTICE: You are using Python 3.6 which is EOL. Starting with v0.62.0, Meson will require Python 3.7 or newer. We can merge now and fix that later, if you like, since that's not really anything to do with your PR.

The Python 3.6 notice isn't actually the cause of the failure, which is explained a few lines above:

meson.build:5:0: ERROR: Compiler clang++ can not compile programs.

I've fixed this in #1092, thanks for merging both!

-- OpenPGP key: 66DE F152 8299 0C21 99EF A801 A8A1 28A8 AB1C EE49

Tachi107 commented 1 year ago

@patrick-kings, could you check if this fixes your issue with CMake FetchContent?

patrick-kings commented 1 year ago

Thank you so much, this works fine

Tachi107 commented 1 year ago

Awesome, thanks for the feedback :D