search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 690 forks source link

build(cmake): fetch GoogleTest from its main branch #1111

Closed shlomnissan closed 1 year ago

shlomnissan commented 1 year ago

build(cmake): fetch GoogleTest from its main branch

dennisjenkins75 commented 1 year ago

Good catch. We'll merge this as soon as CI finishes.

dennisjenkins75 commented 1 year ago

@Tachi107 Do you need to make a corresponding change to the Meson build system (I am not familiar with it)?

dennisjenkins75 commented 1 year ago

@shlomnissan Please edit your PR description to comply with the "commitlint" check.

Tachi107 commented 1 year ago

@shlomnissan thanks for the fix!

@dennisjenkins75 thanks for the ping, but Meson uses a "wrap file" pinned to a specific release (currently 1.11) so it is not needed; see subprojects/gtest.wrap

shlomnissan commented 1 year ago

@Tachi107 No worries :) Thanks for all your hard work!

@dennisjenkins75 I'm not familiar with commitlint. Is it a matter of updating the title/description? I did that but I can't verify/re-run the check.

Tachi107 commented 1 year ago

Il giorno mer 4 gen 2023 alle 12:05:18 -08:00:00, Shlomi Nissan @.***> ha scritto:

I'm not familiar with commitlint. Is it a matter of updating the title/description? I did that but I can't verify/re-run the check

You simply have to reformat you commit message into something like "build(cmake): fetch GoogleTest from its main branch". To rename your commit locally, you can do

$ git commit --amend
$ git push --force