pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 688 forks source link

ci(debian-changelog): last fixes #1123

Closed Tachi107 closed 1 year ago

Tachi107 commented 1 year ago

These should be the last fixes needed to make this work. It does work now in my fork, see https://github.com/Tachi107/pistache/actions/runs/4217592497/jobs/7321484202

Tachi107 commented 1 year ago

After this, the next time version.txt is bumped debian/changelog will be updated by CI

codecov-commenter commented 1 year ago

Codecov Report

Base: 78.60% // Head: 78.58% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (af76a9c) compared to base (294bcb9). Patch has no changes to coverable lines.

:exclamation: Current head af76a9c differs from pull request most recent head 091e943. Consider uploading reports for the commit 091e943 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1123 +/- ## ========================================== - Coverage 78.60% 78.58% -0.02% ========================================== Files 53 53 Lines 6879 6879 ========================================== - Hits 5407 5406 -1 - Misses 1472 1473 +1 ``` | [Impacted Files](https://codecov.io/gh/pistacheio/pistache/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/common/transport.cc](https://codecov.io/gh/pistacheio/pistache/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2NvbW1vbi90cmFuc3BvcnQuY2M=) | `70.30% <0.00%> (-0.31%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tachi107 commented 1 year ago

Ops, I forgot about this PR for some reason. Merging.