pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 688 forks source link

src/server/listener.cc: fix libressl build #1124

Closed ffontaine closed 1 year ago

ffontaine commented 1 year ago

Fix the following libressl build failure:

../src/server/listener.cc: In member function 'void Pistache::Tcp::Listener::setupSSLAuth(const std::string&, const std::string&, int (*)(int, void*))': ../src/server/listener.cc:582:29: error: 'SSL_verify_cb' was not declared in this scope; did you mean 'RSA_verify'?
  582 |                            (SSL_verify_cb)cb
      |                             ^~~~~~~~~~~~~
      |                             RSA_verify

Fixes:

codecov-commenter commented 1 year ago

Codecov Report

Base: 78.60% // Head: 78.58% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (55e5c2f) compared to base (294bcb9). Patch has no changes to coverable lines.

:exclamation: Current head 55e5c2f differs from pull request most recent head 656bff2. Consider uploading reports for the commit 656bff2 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1124 +/- ## ========================================== - Coverage 78.60% 78.58% -0.02% ========================================== Files 53 53 Lines 6879 6879 ========================================== - Hits 5407 5406 -1 - Misses 1472 1473 +1 ``` | [Impacted Files](https://codecov.io/gh/pistacheio/pistache/pull/1124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/server/listener.cc](https://codecov.io/gh/pistacheio/pistache/pull/1124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NlcnZlci9saXN0ZW5lci5jYw==) | `71.11% <ø> (ø)` | | | [include/pistache/async.h](https://codecov.io/gh/pistacheio/pistache/pull/1124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW5jbHVkZS9waXN0YWNoZS9hc3luYy5o) | `89.94% <0.00%> (-0.19%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kiplingw commented 1 year ago

LGTM. @dennisjenkins75 and @Tachi107?

Tachi107 commented 1 year ago

@ffontaine thanks for the patch! Looks good to me as well

Edit: removed the security label as this doesn't fix a security issue, unlike #1104 for example - we don't have a policy on this, but I thought it'd make sense