Open sanjayatn opened 1 year ago
Hi @sanjayatn, thanks for your patch! Could you please add more information about it (comments etc.)?
And rebase too.
@Tachi107 @kiplingw I didn't realized you can see this branch but I love to submit it as a proper PR! Coming up today!
Patch coverage: 26.66
% and project coverage change: -0.12
:warning:
Comparison is base (
a68ad09
) 78.48% compared to head (aa6c74a
) 78.36%.:exclamation: Current head aa6c74a differs from pull request most recent head d268fdc. Consider uploading reports for the commit d268fdc to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@Tachi107 @kiplingw I see two things failing in the checks. Which one should focus on? If you can give me 2 sentence summary of what abidiff / abi step's goal, then I have better idea to fix it.
@kiplingw thanks!
Hi @sanjayatn, thanks for the added description and sorry for the delayed response.
I'm personally not a fan of multiple query parameters because, as you say, the behaviour is not standardized, and differences in how different software components handle them can be a source of security vulnerabilities, so much that this class of vulnerabilities got a name: "HTTP parameter pollution".
That being said, aligning to what others do is probably fine, as long as the others do sensible stuff.
Could you please add a couple of test cases showing this new behaviour? Thanks!
Support Multiple Values for Query Params. In the wikipedia article for https://en.wikipedia.org/wiki/Query_string it says "While there is no definitive standard, most web frameworks allow multiple values to be associated with a single field (e.g.
field1=value1&field1=value2&field2=value3
). Many frameworks support this even though it is not the standard. Currently Pistache supports multiple values separated by a comma by default.This PR adds two enhancements:
,
to allow the rest of the framework to convert values tostd::vector
Query
update method to replace a value in the Query collection.