pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.17k stars 698 forks source link

Add support for custom headers with dash in their names #1136

Closed sjoubert closed 1 year ago

sjoubert commented 1 year ago
sjoubert commented 1 year ago

I'm not sure what is your backward compatibility policy. In doubt I've kept the CUSTOM_HEADER macro, but it should probably be deprecated in favor of the new one. I don't really know how to mark a macro as deprecated though.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (e884d6d) 78.60% compared to head (74f5344) 78.60%.

:exclamation: Current head 74f5344 differs from pull request most recent head 41676ee. Consider uploading reports for the commit 41676ee to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1136 +/- ## ======================================= Coverage 78.60% 78.60% ======================================= Files 53 53 Lines 6884 6884 ======================================= Hits 5411 5411 Misses 1473 1473 ``` | [Impacted Files](https://app.codecov.io/gh/pistacheio/pistache/pull/1136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [include/pistache/http\_header.h](https://app.codecov.io/gh/pistacheio/pistache/pull/1136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW5jbHVkZS9waXN0YWNoZS9odHRwX2hlYWRlci5o) | `90.62% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tachi107 commented 1 year ago

Thanks for the patch, @sjoubert!