search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.17k stars 698 forks source link

Failed to build with GCC 13 #1141

Closed radistmorse closed 1 year ago

radistmorse commented 1 year ago

Building with gcc fails because the file include/pistache/flags.h uses the uint**_t types which are defined in cstdint which is not included. Am I missing something? Obviously you can build the project, do you use other compilers? Do you support GCC?

dennisjenkins75 commented 1 year ago

I suspect that GCC 13 changed the includes used by some of its internal headers, and exposed this latent bug. IMHO, our own sources should "#include " in any header file where we use one of its types. In prior compiler versions, this "just worked" due to (assumed) transitive includes.

dennisjenkins75 commented 1 year ago

PRs are welcome. I am not in a position to test/fix this right now, but others might be.

radistmorse commented 1 year ago

The patch itself is trivial, after I add #include <cstdint> to flags.h it builds. As for the regression tests, I also cannot do it.

a-andre commented 1 year ago

Should be fixed by dabe9fcd3eaaa6b0b8723369b2565778341630c0

radistmorse commented 1 year ago

Works for me.