Closed Tachi107 closed 1 year ago
LGTM @Tachi107. Feel free to merge if CI doesn't break.
Patch coverage has no change and project coverage change: +0.02
:tada:
Comparison is base (
dabe9fc
) 78.43% compared to head (41fd4f9
) 78.46%.:exclamation: Current head 41fd4f9 differs from pull request most recent head b27bacd. Consider uploading reports for the commit b27bacd to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I've turned my pc off already, I'll leave the honour to you ;)
Il 30 giugno 2023 00:31:20 CEST, Kip @.***> ha scritto:
LGTM @Tachi107. Feel free to merge if CI doesn't break.
Using
EXPECT_EQ(var1, var2)
instead ofEXPECT_TRUE(var1 == var2)
offers more helpful error messages in case of test failures. The same goes forEXPECT_STREQ("str1", "str2")
vsEXPECT_EQ(strcmp("str1", "str2"), 0)
.