Closed win32asm closed 10 months ago
Patch coverage has no change and project coverage change: +0.10%
:tada:
Comparison is base (
fe5639a
) 77.92% compared to head (373ca0f
) 78.02%.:exclamation: Current head 373ca0f differs from pull request most recent head 667be05. Consider uploading reports for the commit 667be05 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @win32asm. Can you also remember to document the proposed new build flags in our README.md
?
I'm fine with it. @dennisjenkins75, @Tachi107?
I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?
I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?
Let us see if we can use a pkg-config-based detection way.
I'm not a fan of this workaround. Can't you simply override the pkg-config search directories to include your custom OpenSSL build?
That's actually a really good point.
Thanks for the idea.
We ended up doing
PKG_CONFIG_PATH=<openssl pvt build path>/lib/pkgconfig:${PKG_CONFIG_PATH} \
meson setup build ...
Nice to hear! Happy to help :)
Required in case the openssl library is not native to the build environment (e.g. part of vcpkg fetched dependencies).