Closed Tachi107 closed 8 months ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
fe5639a
) 77.92% compared to head (d1b0718
) 78.07%.:exclamation: Current head d1b0718 differs from pull request most recent head 3d40fd2. Consider uploading reports for the commit 3d40fd2 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Added some more tests and fixed a corner case discovered with the newly added tests. Should be ready now :)
@Tachi107, if your PR passes in CI and @dennisjenkins75 has had a chance to review, I'm totally fine with it. Only thing I'd suggest changing is to bump the patch version.
Only thing I'd suggest changing is to bump the patch version.
Done
Edit: abidiff failures expected, adding new stuff changes the ABI
Debian testing CI runs are failing the Coverage step because of Debian bug https://bugs.debian.org/1053252, it's unrelated to this patch set.
Thanks for the review and merge :)
The new getBestAcceptEncoding() function makes using the new compression support introduced in commit b0b7d3076dcdba48935cfe14049b76809d0cd256 way easier, as it reports to the caller the most sensible content encoding to apply to the response, falling back to the Identity encoding (i.e. no actual compression) in case no encoding is supported by both the server and the client.
Fixes https://github.com/pistacheio/pistache/issues/1148