search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 685 forks source link

Complete BSD support #1180

Open alex0x08 opened 6 months ago

alex0x08 commented 6 months ago

Hi there!

bsd-pistache-porting

Just got it working on FreeBSD 14, with all test cases and release build. Can try to port on NetBSD/OpenBSD too.

Anyone interested?

dennisjenkins75 commented 6 months ago

Woah. That is cool. BSD support also potentially opens up MacOS support.

My main concern is that your PR will need to also add support for automagically running unit tests on Github for the BSDs. I'd love to read your PR.

alex0x08 commented 6 months ago

Ok, need some time to cleanup and create pull-request then. Technically would be possible to adopt solution for MacOS too: https://github.com/jiixyj/epoll-shim

kiplingw commented 6 months ago

Great work @alex0x08. Would you consider being the maintainer for the binary package port? Currently the Debian packaging materials are in a separate debian branch. We could do something similar for FreeBSD and others. I don't know anything at all about packaging on BSD systems.

alex0x08 commented 6 months ago

Just run some tests: image image image

Looks like last one has issues, would need to check.

Would you consider being the maintainer for the binary package port? Currently the Debian packaging materials are in a separate debian branch. We could do something similar for FreeBSD and others. I don't know anything at all about packaging on BSD systems.

Well, technically yes, I could. But don't you think that would be better to use this as 'experimental feature' for a while, and make support only on source level? I've seen some instability when crafted my demo under FreeBSD, also have no real projects on your framework, so hard to predict the amount of work.