search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.17k stars 698 forks source link

fix #1194: Endpoint::Options::backlog_ not used #1195

Closed jiankyu closed 7 months ago

jiankyu commented 7 months ago

This commit passes down the Options::backlog_ in the following invocation: Http::Endpoint::init() -> Tcp::Listener::init()

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.11%. Comparing base (1964b0c) to head (80ca76d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1195 +/- ## ========================================== + Coverage 78.08% 78.11% +0.02% ========================================== Files 53 53 Lines 7077 7077 ========================================== + Hits 5526 5528 +2 + Misses 1551 1549 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kiplingw commented 7 months ago

Thanks @jiankyu. You'll need to update the versioning too. Otherwise it looks good.

jiankyu commented 7 months ago

Thanks @kiplingw for pointing this out. Updated the version, in my time zone it's Feb 23, hope it doesn't make a big deal.

kiplingw commented 7 months ago

LGTM. @Tachi107, if you're fine with it feel free to merge.