search

pistacheio / pistache

A high-performance REST toolkit written in C++
https://pistacheio.github.io/pistache/
Apache License 2.0
3.12k stars 685 forks source link

ci: coverage fails on debian:testing runners #1205

Open dgreatwood opened 2 months ago

dgreatwood commented 2 months ago

gcc produces this error, during the "coverage" phase:

geninfo: ERROR: (unused) 'exclude' pattern '/github/home/.cache/*' is unused.
Excluding file '/usr/include/c++/13/bits/shared_ptr.h'
    (use "geninfo --ignore-errors unused ..." to bypass this error)

While clang produces this error:

geninfo cmd: '/usr/bin/geninfo . --output-filename coverage.info --gcov-tool /github/home/.local/bin/cov.sh --exclude /usr/* --exclude /github/home/.cache/* --exclude */tests/* --exclude */subprojects/*'
Found LLVM gcov version 16.0.6, which emulates gcov version 4.2.0
geninfo: ERROR: Your toolchain version is too old and is no longer supported by lcov.  Please upgrade - or use an older lcov release.

There are a couple of warnings as well, which look unimportant as far as I can see.

Could someone (@Tachi107 ?) fix these errors? Otherwise I guess we could remove debian:testing from the linux.yaml matrix.

Thanks!

Tachi107 commented 2 months ago

Hi Duncan, yeah, I'm aware of those issues and I have attempted fixing them in https://github.com/pistacheio/pistache/pull/1188, but it's far from trivial. Lcov 2.0 introduced some changes that make it incompatible with our CI pipeline, and trying to use gcov directly seemingly doesn't work with Codecov even when following the official documentation. I'm a bit lost and I'm just waiting for Codecov to publish a working solution ¯\_(ツ)_/¯

dgreatwood commented 2 months ago

Makes sense. Leaving this in your hands, but LMK if you’d like me to try something out.

Thanks!

On Wed, Apr 17, 2024 at 10:18 AM Andrea Pappacoda @.***> wrote:

Hi Duncan, yeah, I'm aware of those issues and I have attempted fixing them in #1188 https://github.com/pistacheio/pistache/pull/1188, but it's far from trivial. Lcov 2.0 introduced some changes that make it incompatible with our CI pipeline, and trying to use gcov directly seemingly doesn't work with Codecov even when following the official documentation https://about.codecov.io/tool/gcov/. I'm a bit lost and I'm just waiting for Codecov to publish a working solution ¯_(ツ)_/¯

— Reply to this email directly, view it on GitHub https://github.com/pistacheio/pistache/issues/1205#issuecomment-2061804212, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMA2YQF6CMOT6PFZPVSXLY52VFZAVCNFSM6AAAAABGGIJZVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRHAYDIMRRGI . You are receiving this because you authored the thread.Message ID: @.***>

-- NOTICE: This email and its attachments may contain privileged and confidential information, only for the viewing and use of the intended recipient. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, acting upon, or use of the information contained in this email and its attachments is strictly prohibited and that this email and its attachments must be immediately returned to the sender and deleted from your system. If you received this email erroneously, please notify the sender immediately.  Xage Security, Inc. and its affiliates will never request personal information (e.g., passwords, Social Security numbers) via email.  Report suspicious emails to @. @.>

Tachi107 commented 2 months ago

I've disabled the Coverage step for debian:testing runners in aa2a9f25b64000bd0470c8fd7643c4640b9cdf8f, but I'll keep this issue open to track the actual issue.