search

pitaj / nodebb-plugin-calendar

Fully-featured calendar plugin for NodeBB
42 stars 34 forks source link

Clicking on Calendar Entry no longer works after upgrade to nodebb 16.2 #136

Closed sharked76 closed 3 years ago

sharked76 commented 3 years ago

After updating nodebb to 1.16.2 when I click on any of my calendar entries, nothing happens, the event details overlay that used to pop up does not appear.

When I click the calendar entry, the address bar changes to the event for example: https://members.tirpc.ca/calendar/event/1757

But nothing happens other then the address bar changing. If I put my cursor in the address bar and press Enter, then the event overlay appears.

pitaj commented 3 years ago

What version of the plugin are you on? Are there any errors in your browser JS console or in the NodeBB server logs?

sharked76 commented 3 years ago

Its weird, as it says I have .55 and the latest is .52 ? Nothing in the NodeBB server logs

nodebb-plugin-calendar

Calendar and events for NodeBB

Installed 1.0.0-alpha.55 | Latest 1.0.0-alpha.52

[cid:e6be4e58-ef57-4522-975e-99005a85cf80]

From: Peter Jaszkowiak notifications@github.com Sent: January 30, 2021 1:58 AM To: pitaj/nodebb-plugin-calendar nodebb-plugin-calendar@noreply.github.com Cc: sharked76 sharked76@outlook.com; Author author@noreply.github.com Subject: Re: [pitaj/nodebb-plugin-calendar] Clicking on Calendar Entry no longer works after upgrade to nodebb 16.2 (#136)

What version of the plugin are you on? Are there any errors in your browser JS console or in the NodeBB server logs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pitaj/nodebb-plugin-calendar/issues/136#issuecomment-770169175, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALOYDPM2QCKIK3ZYLJMTDZLS4OUZ5ANCNFSM4WZ65LJQ.

pitaj commented 3 years ago

What about in the JS console in your browser developer tools?

sharked76 commented 3 years ago

Is this what you mean?

[cid:ad7327e6-18a0-4ed5-880f-97752415af1b]

From: Peter Jaszkowiak notifications@github.com Sent: January 30, 2021 2:52 AM To: pitaj/nodebb-plugin-calendar nodebb-plugin-calendar@noreply.github.com Cc: sharked76 sharked76@outlook.com; Author author@noreply.github.com Subject: Re: [pitaj/nodebb-plugin-calendar] Clicking on Calendar Entry no longer works after upgrade to nodebb 16.2 (#136)

What about in the JS console in your browser developer tools?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pitaj/nodebb-plugin-calendar/issues/136#issuecomment-770173895, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALOYDPMZ2NXRBGMXCJLXEN3S4O3EDANCNFSM4WZ65LJQ.

pitaj commented 3 years ago

Your image isn't showing up. Could you upload the image through the GitHub interface instead of email?

sharked76 commented 3 years ago

image

pitaj commented 3 years ago

This is the same issue as #134

You'll need to upgrade to nodebb-plugin-calendar@1.0.0-alpha.56. You can do it manually like so:

npm install nodebb-plugin-calendar@1.0.0-alpha.56

I'm not sure why it isn't showing up as an available upgrade in your ACP.

sharked76 commented 3 years ago

Hi, I tried running: npm install nodebb-plugin-calendar@1.0.0-alpha.56

And I rebuild/restarted NodeBB Still shows this in the ACP:

image

pitaj commented 3 years ago

Where did you run the command? It needs to be run in the nodebb directory.

sharked76 commented 3 years ago

Thanks, I should have known that, I thought npm was systemwide After running npm install nodebb-plugin-calendar@1.0.0-alpha.56 inside the nodebb directory its now working!