runehaubo commented 6 years ago

Hello,

When preparing an update of lmerTest we noticed that simr doesn't pass its checks with the new lmerTest. Please consider this pull request which makes simr work with both current/cran version as well as the upcoming version of lmerTest.

The new version of lmerTest is at https://github.com/runehaubo/lmerTestR. For further information about the new version of lmerTest, please see https://github.com/runehaubo/lmerTestR/blob/master/pkg_notes/new_lmerTest.pdf

Release plans for the new lmerTest are still a bit sketchy as other packages need updates as well, but I wanted to share this PR with you after having played around with simr+lmerTest.

Cheers Rune for the lmerTest developers

pitakakariki commented 6 years ago

Thanks.

Will there be another warning before the new version gets released? I need to tidy up the github version of simr before I push anything to cran, may be a little while before I find the time.

On the other hand I don't want to be the one holding up release so if it gets close to release date I'll expedite the process somehow.

runehaubo commented 6 years ago

Don't worry: I expect 2-3 weeks before we are in place to push lmerTest to CRAN. And we we will reach out before then as well.

Thanks for the quick response.

codecov-io commented 6 years ago

Codecov Report

Merging #101 into master will increase coverage by 14%. The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #101    +/-   ##
========================================
+ Coverage   73.91%   87.91%   +14%     
========================================
  Files          21       21            
  Lines        1081      877   -204     
========================================
- Hits          799      771    -28     
+ Misses        282      106   -176

Impacted Files	Coverage Δ
R/modify.R	`100% <ø> (+15.78%)`	:arrow_up:
R/doSim.R	`100% <0%> (ø)`	:arrow_up:
R/powerPlot.R	`0% <0%> (ø)`	:arrow_up:
R/graphics.R	`0% <0%> (ø)`	:arrow_up:
R/freeze.R
R/newextend.R
R/glmm.R	`100% <0%> (ø)`
R/glm.R	`100% <0%> (ø)`
R/new.R	`100% <0%> (+1.56%)`	:arrow_up:
R/extend.R	`100% <0%> (+3.5%)`	:arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3aaacca...aec34ad. Read the comment docs.

pitakakariki commented 6 years ago

Sorry if you got a bunch of notifications on this, just tidying up.

pitakakariki commented 6 years ago

bump

pitakakariki / simr

Preparing for new version of lmerTest #101

Codecov Report