search

pitakakariki / simr

Power Analysis of Generalised Linear Mixed Models by Simulation
70 stars 19 forks source link

Complex models are not correctly deparsed #250

Closed tobiasrebholz closed 1 year ago

tobiasrebholz commented 1 year ago

Complex models are not correctly deparsed (e.g., in simr::fcompare()) because formulas are broken into character vectors of size larger than one due to usage of deparse() instead of deparse1(). Consequently, fcomparing models is restricted/biased to the formula parts smaller or equal to the default character size 60L of deparse().

pitakakariki commented 1 year ago

Thanks, deparse1 should make this easy to fix.

tobiasrebholz commented 1 year ago

I just created a pull request

pitakakariki commented 1 year ago

Fixed via this pull request: https://github.com/pitakakariki/simr/pull/254