search

pitbulk / moodle_saml

SAML plugins for moodle (authentication and enrollment)
12 stars 24 forks source link

Tests #51

Closed bradjones1 closed 8 years ago

bradjones1 commented 8 years ago

With so many people (apparently) depending on this module, and there being a few PR's and substantial issues pending, we should probably add a CI test process to the project.

Travis CI seems to be the most obvious choice. I don't have time to work on this just this second, so putting up this issue to see if there are any strong thoughts on another platform (e.g., CircleCI) before moving forward with Travis.

@pitbulk I'd probably need you to set up webhooks in the project settings when we make a move.

pitbulk commented 8 years ago

Yes, so many institutions and no much contribution/donation, I already noticed: https://twitter.com/lacarab/status/644152450304339968

If you write in google: allinurl: auth/saml/index.php you will find some of them ;)

I'm using Travis at php-saml toollkit and I'm happy with that service.

You can try to integrate Moodle's code style: https://docs.moodle.org/dev/Coding_style

and add some unit test for some methods.

bradjones1 commented 8 years ago

Well, that's why I'm trying to help. :smile: We all appreciate the work the contributors have put in.

pitbulk commented 8 years ago

any progress?

bradjones1 commented 8 years ago

@pitbulk I've been off the project that uses Moodle for a few weeks but getting back on it this week, thanks for the nudge. First step will be to get Travis up and going with a simple install validation, I think.

bradjones1 commented 8 years ago

@pitbulk I think you may need to set up the Travis integration since I don't have management permissions, and this project is on your personal namespace. Another option would be to create a moodle_saml organization and transfer the ownership there, and then I could help manage the organization. Up to you. Thanks.