search

pitch-foundation / hourglass-sdk

Hourglass SDK
https://pitch-foundation.github.io/hourglass-sdk/
0 stars 1 forks source link

Use more general type for signer #4

Closed bam4564 closed 8 months ago

bam4564 commented 8 months ago

Our signer's used throughout the codebase should not have to be JsonRpcSigner. There are more general base types we can use for signers in ethers 5.7

alex-hourglass commented 8 months ago

Interesting. Can you share more about this reasoning please? Trying to change the JsonRpcSigner to ethers/Signer and I encounter a some issues when integrating with Seaport.

bam4564 commented 8 months ago

The rationale here is that third parties who integrate this might have some other type of signer within their app that is incompatible with the JsonRpcSigner type. After looking at the ethers docs, I think this is fine for now so closing this.