search

pitest / pitclipse

Mutation testing for Java in Eclipse IDE. Based on PIT (Pitest).
https://pitest.org
Apache License 2.0
59 stars 17 forks source link

run menu and runconfigselector to function like the window menu #182

Closed JKutscha closed 3 years ago

JKutscha commented 3 years ago

I rewrote the run menu class and the run configuration selector to be more like the window menu class and that selector. This allows to change more settings without opening the dialog multiple times and will always close the dialog, even if something went wrong.

Also, I am working on #164 and this change will allow easier tests.

LorenzoBettini commented 3 years ago

@echebbi I'm fine with the PR and I'd merge it, do you want to review that as well? I've also tested it locally on KDE. @JKutscha if I understand correctly that's ready for merging, right?

JKutscha commented 3 years ago

@echebbi I'm fine with the PR and I'd merge it, do you want to review that as well? I've also tested it locally on KDE. @JKutscha if I understand correctly that's ready for merging, right?

Yes, it is ready for merging.

echebbi commented 3 years ago

Hello, noticed this PR and its companion are still waiting for being merged. Changes look good to me; can we merge or has something changed since then?

JKutscha commented 3 years ago

Hello, noticed this PR and its companion are still waiting for being merged. Changes look good to me; can we merge or has something changed since then?

Everything is good and can be merged.

LorenzoBettini commented 3 years ago

Merged right now

echebbi commented 3 years ago

Thank you!