search

pitest / pitest-junit5-plugin

JUnit 5 test framework support for Pitest
Apache License 2.0
74 stars 26 forks source link

#73 Force to disable junit5 parallel mode as PIT is not compatible wi… #74

Closed tyge68 closed 1 year ago

tyge68 commented 1 year ago

…th it

hcoles commented 1 year ago

@tyge68 thanks for this.

It sounds like we definitely want to disable parallel mode. Setting the system property directly feels a bit hacky though. I think it should be possible to implement this as an implementation of ConfigurationUpdater. This could add the property to the jvm args of the child processes in the same manner as the existing mac os focus one does in the main pitest repo.

https://github.com/hcoles/pitest/blob/master/pitest-entry/src/main/java/org/pitest/mutationtest/autoconfig/KeepMacOsFocus.java

This has the advantage that the auto adding could be turned off if ever required.

Would you be up for trying this in a pull request? The implementation and tests for the mac os focus updater should provide a good guide (one gotcha being to ensure you create a org.pitest.mutationtest.config.ConfigurationUpdater file in the META-INF/services)

hcoles commented 1 year ago

@tyge68 Having taken another quick look at this, it's not clear that setting this via the config would override the other mechanisms by which it can be set, so merging as is.

Thanks.