search

pitr / angular-rails-templates

Use your angular templates with rails' asset pipeline
https://rubygems.org/gems/angular-rails-templates
MIT License
566 stars 169 forks source link

Deprecation warning from sprockets 3.7.0 #143

Closed anhkind closed 8 years ago

anhkind commented 8 years ago

The current version 1.0.0 seems to give deprecation warning with sprockets 3.7.0, can you help to fix that in the code? Thanks.

DEPRECATION WARNING: Sprockets method `register_engine` is deprecated.
Please register a mime type using `register_mime_type` then
use `register_compressor` or `register_transformer`.
https://github.com/rails/sprockets/blob/master/guides/extending_sprockets.md#supporting-all-versions-of-sprockets-in-processors
 (called from block (3 levels) in <class:Engine> at /Users/user/.rvm/gems/ruby-2.3.0/gems/angular-rails-templates-1.0.0/lib/angular-rails-templates/engine.rb:33)
grosser commented 8 years ago

@pitr did anyone work on a fix for this ?

anhkind commented 8 years ago

I found a fix for the same problem from sass-rails gem here https://github.com/rails/sass-rails/commit/0e85d0d282cdd99f54f91b84f44d059bb6225069, don't know if it helps...

alfie-max commented 8 years ago

Would there be a new release soon with this merge?

bpinto commented 8 years ago

Please? @pitr

pitr commented 8 years ago

v1.0.2 released with this fix

grosser commented 8 years ago

confirmed fixed, please close the issue :)