pitr / angular-rails-templates

Use your angular templates with rails' asset pipeline
https://rubygems.org/gems/angular-rails-templates
MIT License
566 stars 169 forks source link

Rails 6 compatibility #161

Closed tsrivishnu closed 4 years ago

tsrivishnu commented 5 years ago

Is the gem compatible with Rails 6?

hiteshranaut commented 5 years ago

not working with rails 6 can you help? issue I am stuck is where rails 6 need

rails (~> 6.0.0) was resolved to 6.0.0, which depends on
      railties (= 6.0.0)

but angular-rails-templates required < 6 please help if there is a solution for this?

mleone commented 4 years ago

Hi @tsrivishnu @hiteshranaut, I was facing the same issue in my app, and this gem might not actually depend on Rails < 6. I forked this repo and simply changed the rails gem dependency here to allow Rails 6: https://github.com/mleone/angular-rails-templates/commit/c98acac3a74c30ebf3d35521e60cf2966a7d1462

I'm not 100% if this will work for you, but this gem is working properly in my Rails 6 app with that change.

mmoll commented 4 years ago

@pitr Could you pull in that commit and release a new gem?

pitr commented 4 years ago

released in 1.1.0