search

pitr / angular-rails-templates

Use your angular templates with rails' asset pipeline
https://rubygems.org/gems/angular-rails-templates
MIT License
566 stars 169 forks source link

Support for Rails 7.1? #168

Closed epugh closed 11 months ago

epugh commented 12 months ago

Just updated to Rails 7.1 and discovered that this gem explicitly excludes 7.1..

epugh commented 12 months ago

Looks like this is the line preventing 7.1.. https://github.com/pitr/angular-rails-templates/blob/master/angular-rails-templates.gemspec#L19

epugh commented 12 months ago

I gave a quick stab at forking the repo and bumping it: https://github.com/pitr/angular-rails-templates/compare/master...epugh:angular-rails-templates:bump_rails_71?expand=1

I thought I could refer to it in my Gemfile, via 

gem 'angular-rails-templates', git: 'https://github.com/epugh/angular-rails-templates.git', branch: 'bump_rails_71'

but no luck so far..

pughe2 commented 11 months ago

Okay, I figured out my challenge in getting it added to my Gemfile, and now it's working.

mathieujobin commented 11 months ago

Happy to see there is a couple of people still using this gem.

I'll be glad to make a release once you confirm everything is working.

if you open a PR, please stick with < and not <= also update the Github Action workflow file to include running tests on Rails 7.1.1 and make sure all test passes

thank you

mathieujobin commented 11 months ago

released as v1.2.1

epugh commented 11 months ago

Thank you! It's going to be fun to figure out how to support my old AngularJS app and all the new HOTwire/Turbo stuff in Rails 7.1 at the same time.

mathieujobin commented 11 months ago

I do have an app with Angular 1.x and Hotwire. We also have pages using VueJS 2.x

We try not to load different JS framework on the same pages.

its not too bad.. obviously, we would want to deprecate everything old, but too much work for little value