pitr / gemini-ios

Elaho - iOS browser for Gemini protocol
Mozilla Public License 2.0
116 stars 6 forks source link

Request: specify colours and paragraph formatting from within the app #11

Open fincham opened 3 years ago

fincham commented 3 years ago

I’m not sure how the colours are currently chosen but it would be very useful to be able to adjust them from within the app or settings rather than using a user script.

It would also be very useful to be able to select a font and paragraph formatting (eg left, justified, centre etc). In particular “justified” would be very useful.

Thank you for making such an elegant app!

pitr commented 3 years ago

justified makes total sense, I think it should be the default. There is also another ticket #13 for better styling of elements in general. Here are the default styles.

Regarding colors, instead of offering an RGB selector for every type of element, I would rather have sane defaults that everyone would find as the best compromise. There are 2 themes that can be switched in settings: simple black and white, and one based on hash of domain such that same domain has the same look that is different from other capsules. Honestly I am not entirely happy with either. And of course there is the night mode that swaps colors.

fincham commented 3 years ago

Hi Pitr,

Thanks that all makes a lot of sense. Is there an existing Setting panel? I couldn’t work out how to access it even after reading through the source code 😂

Cheers,

Michael


From: ☃ pitr notifications@github.com Sent: Saturday, December 19, 2020 9:47:27 AM To: pitr/gemini-ios gemini-ios@noreply.github.com Cc: Michael Fincham michael@hotplate.co.nz; Author author@noreply.github.com Subject: Re: [pitr/gemini-ios] Request: specify colours and paragraph formatting from within the app (#11)

justified makes total sense, I think it should be the default. There is also another ticket #13https://github.com/pitr/gemini-ios/issues/13 for better styling of elements in general. Here arehttps://github.com/pitr/gemini-ios/blob/master/Client/Frontend/Gemini/GeminiHeader.html the default styles.

Regarding colors, instead of offering an RGB selector for every type of element, I would rather have sane defaults that everyone would find as the best compromise. There are 2 themes that can be switched in settings: simple black and white, and one based on hash of domainhttps://github.com/pitr/gemini-ios/blob/master/Client/Frontend/Gemini/GeminiClient.swift#L387-L395 such that same domain has the same look that is different from other capsules. Honestly I am not entirely happy with either. And of course there is the night mode that swaps colors.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pitr/gemini-ios/issues/11#issuecomment-748310869, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABBLA5I2PECP57CUPXBFAJTSVO5V7ANCNFSM4U7BKRKQ.

pitr commented 3 years ago

It’s under page actions (central button between Forward and Bookmarks)

pitr commented 3 years ago

So I have tried justified text alignment, but the results don't look that good. Usability gains are quite small if any, and they are wiped out by the various side-effects of the justified text which are especially visible on a small screen. I have looked at other iOS apps and haven't found any that justify text (eg see Reader View in Mobile Safari). It just doesn't seem to work well for small devices.

Without justified

simulator_screenshot_12D99646-5F4F-4366-ACAC-C7FA3559A713

With justified

simulator_screenshot_911B314F-1AC5-40B9-A76C-B0F9E2519126