Adding gres handling for teach in crc-interactive

pitt-crc / wrappers

User focused command line wrappers around Slurm

https://crc-pages.pitt.edu/wrappers/

GNU General Public License v3.0

1 stars 1 forks source link

Adding gres handling for teach in crc-interactive #258

Closed yassinkhalifa closed 2 months ago

yassinkhalifa commented 2 months ago

Adding srun's gres parameter handling logic for teach in order to pass the requested gres and set the default num_gpus if not requested when c=teach and p=gpu

djperrefort commented 2 months ago

@yassinkhalifa It looks like you also included changes to crc-idle from PR #257 in this submission. Was that intentional?

yassinkhalifa commented 2 months ago

No, I am sorry for that, it seems I created the branch from the active crc-idle branch at that time and not from main which resulted in including both changes in this PR.

yassinkhalifa commented 2 months ago

I'll get rid of this branch and reset my local branch to main to include only changes related to this issue. Then I'll recreate the PR. Thanks for pointing this out!